Fix thread_local to actually be static #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not tally sure what's going on here, but I've seen tests where a single `thread_local` somehow got multiple versions of a `LocalKey` (one per callsite). My guess is that we need to make them `static` instead of just `const`, but I don't really understand why. Making this change at least forces us to also implement Send/Sync for `LocalKey`, whereas before the compiler didn't ask for it, which suggests the `LocalKey`s weren't being shared like we expected them to be. I wasn't able to write a test that actually exposed the buggy behavior, though -- I can only reproduce it in a release build, which suggests it might be a codegen problem or something.
jamesbornholt
force-pushed
the
thread-local
branch
from
b514ba4
to
5f308bb
Compare
jorajeev
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tally sure what's going on here, but I've seen tests where a single
thread_localsomehow got multiple versions of aLocalKey(one percallsite). My guess is that we need to make them
staticinstead ofjust
const, but I don't really understand why. Making this change atleast forces us to also implement Send/Sync for
LocalKey, whereasbefore the compiler didn't ask for it, which suggests the
LocalKeysweren't being shared like we expected them to be.
I wasn't able to write a test that actually exposed the buggy behavior,
though -- I can only reproduce it in a release build, which suggests it
might be a codegen problem or something.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.